Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

After Effects: base integration with loaders #667

Merged

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Oct 27, 2020

Closes: #663

Implemented:

  • all tools opening and communicating
  • storing metadata into Window > Metadata > Label
  • Loader (tested on .mov, .jpg, .png, .psd, .wav , highlights them in green)
  • Creator (creates assets from Compositions only, highlights them in blue)
    ae_comp

Ready for alpha testing.

Dependencies

🏴 Depends on: ynput/avalon-core#212 and ynput/pype-config#89

@kalisp kalisp self-assigned this Oct 27, 2020
@kalisp kalisp added 2x-dev type: enhancement Enhancements to existing functionality labels Oct 27, 2020
@mkolar mkolar added this to the 2.14 milestone Oct 29, 2020
@mkolar
Copy link
Member

mkolar commented Oct 30, 2020

The base described functionality seems to work well. Loading works on all types that I tried. I have a few things we should probably do.

  • remove the project manager from the panel (it shouldn't be available in the hosts, especially if it doesn't work for us :D )
  • rename the resourceLoader to File Loader so it matches AE default importer and is more familiar to the users.

I'm not sure if you got that far (code looks like you did), but the loaded containers are note being show in the inventory, when I open it. It's always empty. Once that is fixed, I'd we we can merge as alpha and start working on publishing comp renders.

@kalisp
Copy link
Member Author

kalisp commented Nov 2, 2020

Removed Project manager
Fixed Manage
Renamed to FileLoader
Bumped up version of extension to 1.0.1

@kalisp kalisp requested a review from a team November 5, 2020 10:13
kalisp and others added 2 commits November 6, 2020 11:35
Without it it would fail inside of imprint func
@mkolar mkolar merged commit 71ab61f into 2.x/develop Nov 9, 2020
@mkolar mkolar deleted the feature/663-aftereffects-integration-with-websocket branch November 9, 2020 22:10
@mkolar mkolar modified the milestone: 2.14 Nov 17, 2020
@mkolar mkolar changed the title Feature/663 aftereffects integration with websocket After Effects: base integration with loaders Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants